feat: adds parameter scanner_version to the scan command #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the default sonar scann cli version. also fixes quoting warnings by shellcheck Signed-off-by: Kevin Kortum <[email protected]>
Signed-off-by: Kevin Kortum <[email protected]>
Author
|
@antoine-vinot-sonarsource @SamirM-BE Would love to get a review from you for this :) |
Contributor
|
Hi @kevin-kortum-trustedshops, |
Author
|
Hi @antoine-vinot-sonarsource |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the possibility to override the sonar scanner cli version for users of the orb and fixes minor warnings by shellcheck regarding missing quotations to prevent unwanted variable expansions.